Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(engines): add advisory for Node.js >=16.0.0 support #178

Merged
merged 6 commits into from
Jul 6, 2023
Merged

chore(engines): add advisory for Node.js >=16.0.0 support #178

merged 6 commits into from
Jul 6, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 21, 2020

Issue #, if available:
Refs: aws/aws-sdk-js-v3#1558

npmjs docs: https://docs.npmjs.com/files/package.json#engines

Unless the user has set the engine-strict config flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.

Description of changes:
add advisory for Node.js >=10.0.0 support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajewellamz ajewellamz requested a review from a team as a code owner January 10, 2023 16:56
@texastony
Copy link
Contributor

@trivikr do we still need this PR?
Should we update it to >= 16?

texastony
texastony previously approved these changes Jul 6, 2023
@trivikr
Copy link
Member Author

trivikr commented Jul 6, 2023

Should we update it to >= 16?

The version needs to be the minimal version supported by the package.
As of #678, it's Node 16, as long as you're releasing new major version v5.0.0

packages/crc32/package.json Outdated Show resolved Hide resolved
packages/random-source-universal/package.json Outdated Show resolved Hide resolved
packages/random-source-node/package.json Outdated Show resolved Hide resolved
packages/sha256-js/package.json Outdated Show resolved Hide resolved
packages/sha256-universal/package.json Outdated Show resolved Hide resolved
@trivikr trivikr changed the title chore(engines): add advisory for Node.js >=10.0.0 support chore(engines): add advisory for Node.js >=16.0.0 support Jul 6, 2023
@texastony texastony merged commit cb9677d into aws:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants