Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the priority of the AWS_WEB_IDENTITY_TOKEN_FILE/AWS_ROLE_ARN… #1583

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Jan 9, 2020

…/AWS_ROLE_SESSION_NAME environment variables when loading credentials so that they are considered before web_identity_token_file/role_arn/role_session_name profile properties. This is consistent with the other AWS SDKs, including the CLI.

…/AWS_ROLE_SESSION_NAME environment variables when loading credentials so that they are considered before web_identity_token_file/role_arn/role_session_name profile properties. This is consistent with the other AWS SDKs, including the CLI.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

Codecov Report

Merging #1583 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1583      +/-   ##
============================================
+ Coverage     75.56%   75.59%   +0.02%     
  Complexity      638      638              
============================================
  Files           896      896              
  Lines         28064    28064              
  Branches       2214     2214              
============================================
+ Hits          21206    21214       +8     
+ Misses         5843     5835       -8     
  Partials       1015     1015
Flag Coverage Δ Complexity Δ
#unittests 75.59% <0%> (+0.02%) 638 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...k/auth/credentials/DefaultCredentialsProvider.java 31.57% <0%> (ø) 0 <0> (ø) ⬇️
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0%> (-2.86%) 0% <0%> (ø)
.../http/nio/netty/internal/NettyRequestExecutor.java 74.11% <0%> (+5.58%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71af9cf...136395f. Read the comment docs.

@millems millems deleted the millem/fix-credential-priority branch March 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants