service/s3/s3crypto Fix request retries #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing and removing the temp file after send causes retry requests to fail with an error such as: filestore: SerializationError: failed to prepare body for retry caused by: SerializationError: failed to reset request body caused by: SerializationError: failed to get next request body reader caused by: seek /tmp/213721967: file already closed I believe the Complete handler is guaranteed to be called finally after retries attempts have succeeded or been exhausted.
skmcgrail
approved these changes
Jul 20, 2020
jasdel
force-pushed
the
s3crypto-fix-retries
branch
from
ba9551e to
ec6ee22
Compare
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jul 24, 2020
=== ### Service Client Updates * `service/frauddetector`: Updates service API and documentation * `service/fsx`: Updates service documentation * `service/kendra`: Updates service API and documentation * Amazon Kendra now supports sorting query results based on document attributes. Amazon Kendra also introduced an option to enclose table and column names with double quotes for database data sources. * `service/macie2`: Updates service API and documentation * `service/mediaconnect`: Updates service API and documentation * `service/mediapackage`: Updates service API and documentation * The release adds daterange as a new ad marker option. This option enables MediaPackage to insert EXT-X-DATERANGE tags in HLS and CMAF manifests. The EXT-X-DATERANGE tag is used to signal ad and program transition events. * `service/monitoring`: Updates service API and documentation * AWS CloudWatch ListMetrics now supports an optional parameter (RecentlyActive) to filter results by only metrics that have received new datapoints in the past 3 hours. This enables more targeted metric data retrieval through the Get APIs * `service/mq`: Updates service API, documentation, and paginators * Amazon MQ now supports LDAP (Lightweight Directory Access Protocol), providing authentication and authorization of Amazon MQ users via a customer designated LDAP server. * `service/sagemaker`: Updates service API, documentation, and paginators * Sagemaker Ground Truth:Added support for OIDC (OpenID Connect) to authenticate workers via their own identity provider instead of through Amazon Cognito. This release adds new APIs (CreateWorkforce, DeleteWorkforce, and ListWorkforces) to SageMaker Ground Truth service. Sagemaker Neo: Added support for detailed target device description by using TargetPlatform fields - OS, architecture, and accelerator. Added support for additional compilation parameters by using JSON field CompilerOptions. Sagemaker Search: SageMaker Search supports transform job details in trial components. ### SDK Bugs * `service/s3/s3crypto`: Fix client's temporary file buffer error on retry ([#3344](#3344)) * Fixes the Crypto client's temporary file buffer cleanup returning an error when the request is retried.
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jul 24, 2020
Release v1.33.12 (2020-07-24) === ### Service Client Updates * `service/frauddetector`: Updates service API and documentation * `service/fsx`: Updates service documentation * `service/kendra`: Updates service API and documentation * Amazon Kendra now supports sorting query results based on document attributes. Amazon Kendra also introduced an option to enclose table and column names with double quotes for database data sources. * `service/macie2`: Updates service API and documentation * `service/mediaconnect`: Updates service API and documentation * `service/mediapackage`: Updates service API and documentation * The release adds daterange as a new ad marker option. This option enables MediaPackage to insert EXT-X-DATERANGE tags in HLS and CMAF manifests. The EXT-X-DATERANGE tag is used to signal ad and program transition events. * `service/monitoring`: Updates service API and documentation * AWS CloudWatch ListMetrics now supports an optional parameter (RecentlyActive) to filter results by only metrics that have received new datapoints in the past 3 hours. This enables more targeted metric data retrieval through the Get APIs * `service/mq`: Updates service API, documentation, and paginators * Amazon MQ now supports LDAP (Lightweight Directory Access Protocol), providing authentication and authorization of Amazon MQ users via a customer designated LDAP server. * `service/sagemaker`: Updates service API, documentation, and paginators * Sagemaker Ground Truth:Added support for OIDC (OpenID Connect) to authenticate workers via their own identity provider instead of through Amazon Cognito. This release adds new APIs (CreateWorkforce, DeleteWorkforce, and ListWorkforces) to SageMaker Ground Truth service. Sagemaker Neo: Added support for detailed target device description by using TargetPlatform fields - OS, architecture, and accelerator. Added support for additional compilation parameters by using JSON field CompilerOptions. Sagemaker Search: SageMaker Search supports transform job details in trial components. ### SDK Bugs * `service/s3/s3crypto`: Fix client's temporary file buffer error on retry ([#3344](#3344)) * Fixes the Crypto client's temporary file buffer cleanup returning an error when the request is retried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing and removing the temp file after send causes retry requests to
fail with an error such as:
I believe the Complete handler is guaranteed to be called
after retries attempts have succeeded or been exhausted.
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.