Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/signer/v4: Fix X-Amz-Content-Sha256 being in to query for presign #1976

Merged
merged 1 commit into from
Jun 12, 2018

Commits on Jun 12, 2018

  1. aws/signer/v4: Fix X-Amz-Content-Sha256 being in to query for presign

    Fixes the bug which would allow the X-Amz-Content-Sha256 header to be
    promoted to the query string when presigning a S3 request.
    
    This bug also was preventing users from setting their own sha256 value
    for a presigned URL. Presigned requests generated with the custom sha256
    would of always failed with invalid signature.
    
    S3 presign requests without a user specified X-Amz-Content-Sha256 will
    no longer include the X-Amz-Content-Sha256 in the header nor query. The
    X-Amz-Content-Sha256 header only needs to be set if it contains a non
    UNSIGNED-PAYLOAD value.
    
    Fix aws#1974
    jasdel committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    2a7353b View commit details
    Browse the repository at this point in the history