Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/request: Fix bug in request presign creating invalide URL #1624

Merged
merged 4 commits into from
Nov 1, 2017

Commits on Nov 1, 2017

  1. aws/request: Fix bug in request presign creating invalide URL

    Fixes a bug the Request Presign and PresignRequest methods that would
    allow a invalid expire duration as input. A expire time of 0 would be
    interpreted by the SDK to generate a normal request signature, not a
    presigned URL. This caused the returned URL unusable.
    
    Added validation to the presign methods to return an error if the expire
    duration is 0 or less.
    
    Even though this is a change in functionality a expire duration less
    than 1 is invalid and would not work. http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-query-string-auth.html
    
    Fix aws#1617
    jasdel committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    f26031a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d363a3 View commit details
    Browse the repository at this point in the history
  3. cleanup test

    jasdel committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    f8a0aa3 View commit details
    Browse the repository at this point in the history
  4. fixtypo

    jasdel committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    0df6699 View commit details
    Browse the repository at this point in the history