Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request to add support for APIGateway #338

Closed
zollie opened this issue Aug 6, 2015 · 6 comments
Closed

Feature request to add support for APIGateway #338

zollie opened this issue Aug 6, 2015 · 6 comments
Labels
feature-request A feature should be added or improved.

Comments

@zollie
Copy link

zollie commented Aug 6, 2015

This is a feature request for adding APIGateway support to the go SDK.

I realize it's a HAL API but I think it should still be callable in the standard RESTful way?
@jasdel jasdel added the feature-request A feature should be added or improved. label Aug 6, 2015
@jasdel
Copy link
Contributor

jasdel commented Aug 6, 2015

Thanks for the suggestion @zollie. Adding this functionality is in our backlog since the SDK does not support the HAL protocol.

@radeksimko
Copy link
Contributor

👍

@jasdel jasdel mentioned this issue Oct 13, 2015
Closed
@hopkinsth
Copy link

Not sure how much of a priority this is, but it would be nice to have support for it to automate Lambda + API gateway in particular.

For those looking for a (temporary) alternative, you might want to check out halgo. I don't yet know if it will do all that you need outside signing requests to Amazon, so YMMV!

@jasdel
Copy link
Contributor

jasdel commented Oct 20, 2015

Thanks for the votes, and information on halgo. I haven't see that library before. When we add support for API Gateway it would be fore the full service API. So you can expect full feature functionality once support is added. When API Gateway is supported in the SDK you can expect it to follow existing supported services operation request/response patterns.

@jasdel jasdel closed this as completed in a277023 Oct 26, 2015
jasdel added a commit that referenced this issue Oct 26, 2015
@jasdel
Tag release v0.9.17
1481c91 
References:
  #338
@jasdel
Copy link
Contributor

jasdel commented Oct 26, 2015

HI @zollie @radeksimko @hopkinsth I just pushed an update which adds support for the API Gateway API. You should now be able to start using API Gateway's API calls using the Go SDK with release v0.9.17.

@hopkinsth
Copy link

Excellent, @jasdel! Hoping to build this into an application ASAP. Thanks!

@danielrmeyer danielrmeyer mentioned this issue Oct 28, 2015
Closed
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
@skmcgrail
Release v0.20.0 (2020-03-17) (aws#507)
2930532 
Breaking Change
---
* Update SDK retry behavior
  * Significant updates were made the SDK's retry behavior. The SDK will now retry all connections error. In addition, to changing what errors are retried the SDK's retry behavior not distinguish the difference between throttling errors, and regular retryable errors. All errors will be retried with the same backoff jitter delay scaling.
  * The SDK will attempt an operation request 3 times by default. This is one less than the previous initial request with 3 retires.
  * New helper functions in the new `aws/retry` package allow wrapping a `Retrier` with custom behavior, overriding the base `Retrier`, (e.g. `AddWithErrorCodes`, and `AddWithMaxAttempts`)
* Update SDK error handling
  * Updates the SDK's handling of errors to take advantage of Go 1.13's new `errors.As`, `Is`, and `Unwrap`. The SDK's errors were updated to satisfy the `Unwrap` interface, returning the underlying error.
  * With this update, you can now more easily access the SDK's layered errors, and meaningful state such as, `Timeout`, `Temporary`, and other states added to the SDK such as `CanceledError`.
* Bump SDK minimum supported version from Go 1.12 to Go 1.13
  * The SDK's minimum supported version is bumped to take advantage of Go 1.13's updated `errors` package.

Services
---
* Synced the V2 SDK with latest AWS service API definitions.

SDK Features
---
* `aws`: Add Support for additional credential providers and credential configuration chaining ([aws#488](aws/aws-sdk-go-v2#488))
  * `aws/processcreds`: Adds Support for the Process Credential Provider
    * Fixes [aws#249](aws/aws-sdk-go-v2#249)
  * `aws/stscreds`: Adds Support for the Web Identity Credential Provider
    * Fixes [aws#475](aws/aws-sdk-go-v2#475)
    * Fixes [aws#338](aws/aws-sdk-go-v2#338)
  * Adds Support for `credential_source`
    * Fixes [aws#274](aws/aws-sdk-go-v2#274)
* `aws/awserr`: Adds support for Go 1.13's `errors.Unwrap` ([aws#487](aws/aws-sdk-go-v2#487))
* `aws`: Updates SDK retry behavior ([aws#487](aws/aws-sdk-go-v2#487))
  * `aws/retry`: New package defining logic to determine if a request should be retried, and backoff.
  * `aws/ratelimit`: New package defining rate limit logic such as token bucket used by the `retry.Standard` retrier.

SDK Enhancements
---
* `aws`: Add grouping of concurrent refresh of credentials ([aws#503](aws/aws-sdk-go-v2#503))
  * Concurrent calls to `Retrieve` are now grouped in order to prevent numerous synchronous calls to refresh the credentials. Replacing the mutex with a singleflight reduces the overall amount of time request signatures need to wait while retrieving credentials. This is improvement becomes pronounced when many requests are made concurrently.
* `service/s3/s3manager`: Improve memory allocation behavior by replacing sync.Pool with custom pool implementation
  * Improves memory allocations that occur when the provided `io.Reader` to upload does not satisfy both the `io.ReaderAt` and `io.ReadSeeker` interfaces.

SDK Bugs
---
* `service/s3/s3manager`: Fix resource leaks when the following occurred:
  * Failed CreateMultipartUpload call
  * Failed UploadPart call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@radeksimko @hopkinsth @jasdel @zollie