Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/client: Fix broken Throttle Retry test case #2795

Closed
skotambkar opened this issue Aug 28, 2019 · 0 comments · Fixed by #2796 or #2805
Closed

aws/client: Fix broken Throttle Retry test case #2795

skotambkar opened this issue Aug 28, 2019 · 0 comments · Fixed by #2796 or #2805
Assignees
@skotambkar
Labels
bug This issue is a bug.

Comments

@skotambkar
Copy link
Contributor

The test for retry throttle cap (TestRetryDelay) is broken and doesn't test the behavior correctly.

Related to PR #1654
@skotambkar skotambkar self-assigned this Aug 28, 2019
@skotambkar skotambkar mentioned this issue Aug 28, 2019
Merged
@jasdel jasdel added the bug This issue is a bug. label Aug 28, 2019
jasdel pushed a commit that referenced this issue Aug 29, 2019
@skotambkar @jasdel
aws/client: Updates logic for request retry delay calculation (#2796)
d1c74a6 
Updates logic for calculating the delay after which a request can be retried. Retry delay now includes the Retry-After duration specified in a request. Fixes broken test for Throttle Retry cap.

Fixes #2795
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skotambkar skotambkar

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
2 participants
@jasdel @skotambkar