Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit dependency manager file for deterministic builds #1451

Closed
dfuentes77 opened this issue Aug 7, 2017 · 3 comments
Closed

commit dependency manager file for deterministic builds #1451

dfuentes77 opened this issue Aug 7, 2017 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@dfuentes77
Copy link

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

all

Version of Go (go version)?

all

What issue did you see?

Would love it if you committed a dependency manager file, e.g. glide.yaml/glide.lock for Glide.sh or Godeps/Godeps.json for Godep. This allows a smart dependency manager like Glide to auto detect what your project dependencies are and what versions to get, and pull them down, instead of always pulling master.
@jasdel jasdel added the feature-request A feature should be added or improved. label Aug 7, 2017
@jasdel
Copy link
Contributor

jasdel commented Aug 7, 2017

Thanks for contacting us @dfuentes77 I've been experimenting with the dep project for annotating which dependencies the SDK needs. Before we do this we're looking at ways of simplifying the SDK's code generation dependencies to not pollute the SDK's dependence list.

@jasdel jasdel mentioned this issue Sep 23, 2017
Merged
@jasdel
Copy link
Contributor

jasdel commented Sep 23, 2017

I created a PR #1544 which adds the dep metadata files to the SDK. This will allow applications to correctly manage the SDK's dependencies in the context of the application. I think this will resolve the issues experiences with the un-versioned vendor folder.

jasdel added a commit that referenced this issue Sep 25, 2017
@jasdel
Add dep Go dependency management metadata files (#1544)
22de44e 
Adds the dep Go dependency management metadata files to the SDK. The Gopkg files allow your tools to detect the version of dependencies the SDK uses.

Non-runtime dependencies such as test, example, and code generation packages are excluded from the Gopkg files as they are not needed to use the SDK.

Fix #1451
Fix #634
@awstools awstools mentioned this issue Sep 26, 2017
Merged
@dfuentes77
Copy link
Author

Awesome, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfuentes77 @jasdel