Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put EnvConfigCredentials in constant #1444

Closed
etsangsplk opened this issue Aug 3, 2017 · 1 comment
Closed

Put EnvConfigCredentials in constant #1444

etsangsplk opened this issue Aug 3, 2017 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@etsangsplk
Copy link

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

master

Version of Go (go version)?

1.7

What issue did you see?

Steps to reproduce

ProviderName: "EnvConfigCredentials",

aws-sdk-go/aws/session/env_config.go

Line 160 in 5f43689

cfg.Creds.ProviderName = "EnvConfigCredentials"

If you have have an runnable example, please include it.
@jasdel
Copy link
Contributor

jasdel commented Aug 3, 2017

Thanks for pointing this out @etsangsplk. Yeah this value should definitely be a constant. If you're looking to create a PR we'd be glad to review it. In this case constant name of EnvProviderName probably is good. We probably can do this same for the static credential provider in the same package as well if its doesn't already use a constant.

@jasdel jasdel added the feature-request A feature should be added or improved. label Aug 3, 2017
@elliott-beach elliott-beach mentioned this issue Sep 16, 2017
Merged
jasdel pushed a commit that referenced this issue Sep 19, 2017
@elliott-beach @jasdel
aws/credentials: Add EnvProviderName constant. (#1531)
454fa19 
Adds the "EnvConfigCredentials" string literal as EnvProviderName constant.

Fix #1444
@awstools awstools mentioned this issue Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasdel @etsangsplk