Cleanup unneeded wrapping of values in aws and stscreds package (#2707)

Cleans up unneeded wrapping of values in the aws and stscreds package: * aws: removes pointer dereference for `IsZero` method call. * stscreds: removes anonymous function wrapping `time.Now`
aws · Jul 22, 2019 · fe1e95e · fe1e95e
1 parent 5516892
commit fe1e95e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/aws/convert_types_test.go b/aws/convert_types_test.go
@@ -562,7 +562,7 @@ func TestTimeValueSlice(t *testing.T) {
 		}
 		for i := range out2 {
 			if in[i] == nil {
-				if !(*(out2[i])).IsZero() {
+				if !(out2[i]).IsZero() {
 					t.Errorf("Unexpected value at idx %d", idx)
 				}
 			} else {

diff --git a/aws/credentials/stscreds/web_identity_provider.go b/aws/credentials/stscreds/web_identity_provider.go
@@ -26,9 +26,7 @@ const (
 // now is used to return a time.Time object representing
 // the current time. This can be used to easily test and
 // compare test values.
-var now = func() time.Time {
-	return time.Now()
-}
+var now = time.Now
 
 // WebIdentityRoleProvider is used to retrieve credentials using
 // an OIDC token.