fix several waiter issues #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Jan 13, 2025
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
Why do we need 2 separate changelogs?
There was a problem hiding this comment.
It's two different fixes, the nil deref one only applies to ec2
There was a problem hiding this comment.
Like, as in one is totally unrelated to the other. Only the unmatched error one is "sensitive" and associated with the discussion post.
There was a problem hiding this comment.
Right, by bumping smithy-go we got those two
wty-Bryant
approved these changes
Jan 13, 2025
Madrigal
approved these changes
Jan 13, 2025
lucix-aws
force-pushed
the
fix-waiters
branch
from
6ddbaf5 to
d2a234c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2937
tracks codegen changes to prevent nil deref errors in waiters from aws/smithy-go#562