BREAKFIX: Only generate AccountIDEndpointMode config for services that use it #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Sep 17, 2024
Madrigal
approved these changes
Sep 17, 2024
| } | ||
|
|
||
| var rules = service.expectTrait(EndpointRuleSetTrait.class).getEndpointRuleSet(); | ||
| for (var param : rules.getParameters()) { |
There was a problem hiding this comment.
this looks perfect for a stream, but Parameters is not a collection so while doable it's very awkward to handle it as such, so I like this version better
There was a problem hiding this comment.
There's no way to actually get a stream of Parameters that I could see. You can either iterate them, get() by string, or there's a forEach.
There was a problem hiding this comment.
Again it's super awkward to do via streams and I like your version better, but just for completion sake, you could wrap the Parameters spliterator using StreamSupport
return StreamSupport.stream(rules.getParameters().spliterator(), false)
.map(x -> x.getBuiltIn().orElse(""))
.anyMatch(x -> x.equals("AWS::Auth::AccountId"));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only generate AccountIDEndpointMode config for services that use it. This is a compiler break, but removes no actual functionality, as no services currently use the account ID in endpoint resolution.
Relevant commit here is fd86578