-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ini2 parser #2365
Merged
feat: ini2 parser #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaiahvita
approved these changes
Nov 10, 2023
wty-Bryant
approved these changes
Nov 10, 2023
isaiahvita
approved these changes
Nov 13, 2023
wty-Bryant
approved these changes
Nov 13, 2023
This was referenced Nov 15, 2023
ewbankkit
added a commit
to hashicorp/aws-sdk-go-base
that referenced
this pull request
Nov 20, 2023
ewbankkit
added a commit
to hashicorp/aws-sdk-go-base
that referenced
this pull request
Nov 20, 2023
This was referenced Jan 15, 2024
PhillipGameDev
added a commit
to PhillipGameDev/AWS-SDK-GO-BACKEND
that referenced
this pull request
Dec 10, 2024
PhillipGameDev
added a commit
to PhillipGameDev/AWS-SDK-GO-BACKEND
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the legacy, undocumented, and unmaintainable shared config parser with a vastly simplified implementation.
Parse failures (unrecognized tokens) will now silently be ignored rather than dropping the entire profile, and the implementation is much more lenient in general.
I've included the benchmarks provided courtesy of @krousey in #2353 and we actually observe a performance boost from this reimplementation:
old:
new: