Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate clients with ErrorCodeOverride #1969

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

eddy-aws
Copy link
Contributor

@eddy-aws eddy-aws commented Dec 27, 2022

Adds ErrorCodeOverride field to all error structs, and modifies
the ErrorCode() method to return ErrorCodeOverride if present.

This change regenerates clients for aws/smithy-go#401.

@eddy-aws eddy-aws requested a review from a team as a code owner December 27, 2022 21:21
@eddy-aws eddy-aws mentioned this pull request Dec 27, 2022
@syall syall changed the title Regenerate clients Regenerate clients with ErrorCodeOverride Dec 28, 2022
Adds `ErrorCodeOverride` field to all error structs, and modifies
the `ErrorCode()` method to return `ErrorCodeOverride` if present.

This change regenerates clients for aws/smithy-go#401.
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the diffs offline, seems like expected error struct diffs are happening:

  • Adding the ErrorCodeOverride *string member
  • Updating the corresponding ErrorCode() method

@isaiahvita isaiahvita merged commit 2998a98 into aws:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants