Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Op and Sep Tokens in Expression Values #1324

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

skmcgrail
Copy link
Member

Allows for :, =, [, and ] to be present in expression values.

Related: aws/aws-sdk-go#3958

@skmcgrail skmcgrail requested review from skotambkar and jasdel June 30, 2021 16:45
Copy link
Contributor

@skotambkar skotambkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor testing and documentation call out

internal/ini/testdata/valid/op_sep_in_values Outdated Show resolved Hide resolved
internal/ini/visitor.go Show resolved Hide resolved
@skmcgrail skmcgrail requested a review from skotambkar June 30, 2021 21:04
@skmcgrail skmcgrail force-pushed the iniFixes branch 3 times, most recently from 63b3ad7 to c1a2546 Compare June 30, 2021 21:17
@skmcgrail skmcgrail force-pushed the iniFixes branch 2 times, most recently from 8bb502d to 36a468c Compare June 30, 2021 21:44
internal/ini/ini_parser.go Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the iniFixes branch 3 times, most recently from f5d4072 to 60d198c Compare June 30, 2021 22:34
@skmcgrail skmcgrail merged commit eb286a1 into aws:main Jul 1, 2021
@skmcgrail skmcgrail deleted the iniFixes branch November 8, 2021 18:07
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
* Support Op and Sep Tokens in Expression Values
* Additional Test Cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants