aws/signer/v4: Keep Object-Lock headers a header in presigning signing requests #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Jun 18, 2021
skotambkar
approved these changes
Jun 18, 2021
jasdel
force-pushed
the
pr1215/PresignAsHeaderObjectLock
branch
from
d08da64 to
2391f32
Compare
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jun 18, 2021
Updates the SigV4 signer to exlucde the X-Amz-Object-Lock- group of headers to not be signed as a part of the query string for presigned URLs. Related to aws/aws-sdk-go-v2#1307
skotambkar
approved these changes
Jun 18, 2021
jasdel
added a commit
to aws/aws-sdk-go
that referenced
this pull request
Jun 18, 2021
…3968) Updates the SigV4 signer to exclude the X-Amz-Object-Lock- group of headers to not be signed as a part of the query string for presigned URLs. Related to aws/aws-sdk-go-v2#1307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Sigv4 request signer to use keep
X-Amz-Object-Lock-*headers as headers, and not hoisted to the query string for presigned URLs.Revision of #1215