Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/signer/v4: Keep Object-Lock headers a header in presigning signing requests #1307

Merged
merged 4 commits into from
Jun 18, 2021

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jun 18, 2021

Updates the Sigv4 request signer to use keep X-Amz-Object-Lock-* headers as headers, and not hoisted to the query string for presigned URLs.

Revision of #1215

@jasdel jasdel force-pushed the pr1215/PresignAsHeaderObjectLock branch from d08da64 to 2391f32 Compare June 18, 2021 17:54
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Jun 18, 2021
Updates the SigV4 signer to exlucde the X-Amz-Object-Lock- group of
headers to not be signed as a part of the query string for presigned
URLs.

Related to aws/aws-sdk-go-v2#1307
@jasdel jasdel merged commit e216071 into aws:main Jun 18, 2021
jasdel added a commit to aws/aws-sdk-go that referenced this pull request Jun 18, 2021
…3968)

Updates the SigV4 signer to exclude the X-Amz-Object-Lock- group of headers to not be signed as a part of the query string for presigned URLs.

Related to aws/aws-sdk-go-v2#1307
@jasdel jasdel deleted the pr1215/PresignAsHeaderObjectLock branch June 18, 2021 18:52
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
…g requests (aws#1307)

Updates the Sigv4 request signer to use keep X-Amz-Object-Lock-* headers as headers, and not hoisted to the query string for presigned URLs.

Revision of aws#1215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants