Fixing changelog description and implementation to use TrimSpace

aws · Oct 28, 2024 · 803614d · 803614d
1 parent b12c8cf
commit 803614d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.changelog/f63b26b19e2e4330b4240f38088453ea.json b/.changelog/f63b26b19e2e4330b4240f38088453ea.json
@@ -1,7 +1,7 @@
 {
     "id": "f63b26b1-9e2e-4330-b424-0f38088453ea",
     "type": "bugfix",
-    "description": "Adding logic to omit whitespaces in the signature, and test coverage",
+    "description": "Improve handling of whitespace (or lack thereof) in sigv4 GetSignedRequestSignature.",
     "modules": [
         "."
     ]

diff --git a/aws/signer/v4/middleware.go b/aws/signer/v4/middleware.go
@@ -374,7 +374,7 @@ func GetSignedRequestSignature(r *http.Request) ([]byte, error) {
 	if auth := r.Header.Get(authorizationHeader); len(auth) != 0 {
 		ps := strings.Split(auth, ",")
 		for _, p := range ps {
-			p = strings.Trim(p, " ")
+			p = strings.TrimSpace(p)
 			if idx := strings.Index(p, authHeaderSignatureElem); idx >= 0 {
 				sig := p[len(authHeaderSignatureElem):]
 				if len(sig) == 0 {