Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sync integration tests with ruby #6043

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Oct 5, 2023

Which issue(s) does this change fix?

N/A

Update ruby version 3.2 to match with integration test environment for sam sync tests.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner October 5, 2023 19:01
@mndeveci mndeveci requested review from jfuss and moelasmar October 5, 2023 19:01
@moelasmar
Copy link
Contributor

it looks good to me, but to understand the problem, is the problem that the default ruby version in appveyor is 3.2, and we need to set the ruby2.7 in front of the path to use it. As, I can see that ruby3.2 is installed in both ubuntu and windows appveyor images

@mndeveci
Copy link
Contributor Author

mndeveci commented Oct 5, 2023

it looks good to me, but to understand the problem, is the problem that the default ruby version in appveyor is 3.2, and we need to set the ruby2.7 in front of the path to use it. As, I can see that ruby3.2 is installed in both ubuntu and windows appveyor images

It uses that line in Gemfile to recommend using specific ruby version, bundler fails otherwise. I can also remove that line and just update the ruby version in template to use the 3.2 since 2.7 is going to be deprecated soon.

@mndeveci mndeveci added this pull request to the merge queue Oct 5, 2023
Merged via the queue into aws:develop with commit 67cd547 Oct 5, 2023
78 checks passed
moelasmar pushed a commit to moelasmar/aws-sam-cli that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants