Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating region extraction from headbucket headers, and adding logging for debugging #104

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

shiva958
Copy link
Collaborator

@shiva958 shiva958 commented Jan 16, 2024

Issue #, if available:
Currently, the region for a bucket will only be extracted if the head bucket request is successful. However, S3 returns bucket region as a response header for failure cases. Adding logic to extract the region from headers if there is an exception and if the header contains the region.

Description of changes:

  • Modifying logic to extract region from the head bucket response headers.
  • Refactoring logging statements to ensure that better information is available during debugging.
  • Updating unit and integration tests that failed with the head bucket response changes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@amitvc amitvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiva958 shiva958 marked this pull request as ready for review January 16, 2024 20:41
@shiva958 shiva958 requested a review from a team as a code owner January 16, 2024 20:41
@shiva958 shiva958 merged commit bd73a1b into main Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants