fix(pipeline): fix feature branch pipeline creation for bare PDKPipel… #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inePyProject This fixes the CodeBuild buildspec that creates feature branch pipelines by preventing the inclusion of a `"cd "` command in before running `cdk synth`. Changes: * Add an optional `cdkSrcDir` prop to `PDKPipeline` in case the assumption that `cdk.out` and `cdk.json` are in the same directory is incorrect for the project. * Use `path.dirname()` to determine the default `cdkSrcDir` from the `primarySynthDir` to handle the case that it is the project root. fix #462
agdimech
approved these changes
Sep 7, 2023
|
I really like the fact that you are testing with CodeArtifact. I have a planned feature #548 which will add native capability to the PDK to accomplish this in JAVA/PY/NPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inePyProject
This fixes the CodeBuild buildspec that creates feature branch pipelines by preventing the inclusion of a
"cd "command in before runningcdk synth.Changes:
cdkSrcDirprop toPDKPipelinein case the assumption thatcdk.outandcdk.jsonare in the same directory is incorrect for the project.path.dirname()to determine the defaultcdkSrcDirfrom theprimarySynthDirto handle the case that it is the project root.I tested this with a prerelease package in CodeArtifact.
Fixes #462