Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for g6 and m7 family instances. #356

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

svanhool
Copy link
Contributor

@svanhool svanhool commented Sep 5, 2024

Description

Some AWS Regions have G6 and M7 instances deployed. This change adds support for those.

Changes

Add G6 and M7 instances to drop down menu.

How Has This Been Tested?

My colleagues have been using the m7i instance type for their head nodes for a few months without any issues.

References

https://aws.amazon.com/ec2/instance-types/g6/
https://aws.amazon.com/ec2/instance-types/m7a/
https://aws.amazon.com/ec2/instance-types/m7i/

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I made sure that any GitHub issue solved by this PR is correctly linked
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreambeyondorange
Copy link
Collaborator

Thank you for this PR!

@dreambeyondorange dreambeyondorange merged commit f3454dd into aws:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants