Remove -fno-exceptions #832
Merged
+2
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the -fno-exceptions C++ compiler flags. NCCL currently does not build with the flag, so removing it here should not have a performance impact and will make it easier to handle errors from constructors/deconstructors and STL libraries. Signed-off-by: Aviv Benchorin <benchori@amazon.com>
Removes checking for NULL after allocating with `new`. Since `(std::nothrow)` was not used to specify non-throwing allocators, errors in the constructor would just throw an exception rather than return NULL, making the NULL checks unnecessary. Signed-off-by: Aviv Benchorin <benchori@amazon.com>
bwbarrett
approved these changes
Mar 27, 2025
rauteric
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
-fno-exceptionsC++ compiler flags. NCCL currently does not build with the flag, so removing it here should not have a performance impact and will make it easier to handle errors from constructors/deconstructors and STL libraries.Also removes checking for NULL after allocating with
new. Since(std::nothrow)was not being used to specify non-throwing allocators, errors in the constructor would just throw an exception rather than return NULL, making the NULL checks unnecessary. With-fno-exceptionsremoved, the exception will now be propagated up the stack.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.