Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdma: Set LOW_LATENCY traffic class for control #702

Merged
1 commit merged into from
Nov 15, 2024

Conversation

bwbarrett
Copy link
Contributor

Set a priority traffic class (LOW_LATENCY) for the control queue pair. Providers should silently fall back to TC_UNSPEC in the case that LOW_LATENCY is not available, so there's no fallback in this code. The traffic class interface was added in Libfabric 1.9.0 and configure requires at least Libfabric 1.11.0, so there's no need to add backward compatibility #ifdefs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwbarrett
Copy link
Contributor Author

Leaving this as a draft until the EFA provider end to end TC setting works.

rajachan
rajachan previously approved these changes Nov 7, 2024
ghost
ghost previously approved these changes Nov 7, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwbarrett bwbarrett force-pushed the feature/tc-all-the-control-things branch from 1c28a92 to 361e0ad Compare November 12, 2024 18:17
@ghost
Copy link

ghost commented Nov 12, 2024

bot:aws:retest

@bwbarrett
Copy link
Contributor Author

bot:aws:retest

Test CUDA failure common.cu:294 'uncorrectable ECC error encountered'

Set a priority traffic class (LOW_LATENCY) for the control queue pair.
Providers should silently fall back to TC_UNSPEC in the case that
LOW_LATENCY is not available, so there's no fallback in this code.
The traffic class interface was added in Libfabric 1.9.0 and configure
requires at least Libfabric 1.11.0, so there's no need to add backward
compatibility #ifdefs.

Signed-off-by: Brian Barrett <bbarrett@amazon.com>
@bwbarrett bwbarrett dismissed stale reviews from ghost and rajachan via d28dc99 November 13, 2024 22:47
@bwbarrett bwbarrett force-pushed the feature/tc-all-the-control-things branch from 361e0ad to d28dc99 Compare November 13, 2024 22:47
@ghost ghost added this to the 1.13.x milestone Nov 14, 2024
@ghost ghost marked this pull request as ready for review November 14, 2024 18:32
@ghost ghost self-requested a review as a code owner November 14, 2024 18:32
@ghost ghost merged commit 2e01f60 into aws:master Nov 15, 2024
27 checks passed
@bwbarrett bwbarrett deleted the feature/tc-all-the-control-things branch November 15, 2024 21:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants