Add a proper endpoint interface #654
Merged
+350
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
force-pushed
the
feature/endpoint-interface
branch
5 times, most recently
from
1720838 to
e0e8b81
Compare
With recent changes, we no longer use thread local storage for endpoint storage, so the thread local ep type flag doesn't make much sense. Change the name to be exactly what's happening (which also flips the logic), and remove an unnecessary check of a parameter in the cleanup path. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
The ep_lock was originally used to just protect the endpoint table, but there are other device structures that should be protected as well, so rename the lock before widening its use. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
In preparation of adding a domain object to clean up some of the thread code, add a proper base object management interface in the base code so that we don't have two implementations doing the same thing. This isn't perfect, because the way we implement the endpoint per communicator code is a little hokey, but cleaning that up will be simpler when there's a proper domain object. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
force-pushed
the
feature/endpoint-interface
branch
from
e0e8b81 to
9986622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of adding a domain object to clean up some of the thread code, add a proper base object management interface in the base code so that we don't have two implementations doing the same thing. This isn't perfect, because the way we implement the endpoint per communicator code is a little hokey, but cleaning that up will be simpler when there's a proper domain object.
There's two small cleanup patches as well to help prep for the endpoint choice.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.