-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdma: do local RDMA read on all NIC rails for flush() #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence in your patch is misleading. The flush function is never disabled. It's just not called in some situations.
Please drop the merge commit and squash your fixups. A rebased branch is here: https://github.com/aws-nslick/nccl-net-ofi/tree/taeil-flush-rebased You can do this locally by just calling:
|
8361649
to
497d444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two small nits, looks good to me.
This changes flush() implementation in such a way that local RDMA read is requested to all NIC rails for multi-rail cases. This is to make sure all data traffic paths are safely flushed from all NICs to GPU. Signed-off-by: Taeil Um <taeilum@amazon.com>
This changes flush() implementation in such a way that local RDMA read is requested to all NIC rails for multi-rail cases. This is to make sure all data traffic paths are safely flushed from all NICs to GPU.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.