.ci/aws: All CI use ami with EFA Installer #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the p3dn AL2 ami building was broken, so we pinned it to a fixed AMI that happened to not have the EFA Installer in it. Now that the p3dn AMI building is fixed, make the CI use AMI's with EFA Installers already baked into them. This will speed up our CI, and will reduce the amount of infra related errors that we see. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
a-szegel
force-pushed
the
all-tests-use-prebuilt-efa-installer
branch
from
fe71fe8 to
58a97eb
Compare
|
I saw an EFA Installer failure in a CI run, and realized we shouldn't be installing it on any of the AMI's (not just p4/p5) |
ghost
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the p3dn AL2 ami building was broken, so we pinned it to a fixed AMI that happened to not have the EFA Installer in it. Now that the p3dn AMI building is fixed, make the CI use AMI's with EFA Installers already baked into them. This will speed up our CI, and will reduce the amount of infra related errors that we see.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.