fix(rdma): send periodic control messages to sync sender/receiver #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
force-pushed
the
rdma_ctrl_sync_fix
branch
from
fc22f71 to
a418a10
Compare
|
Refactored some of the logic to avoid duplicate code. |
rauteric
force-pushed
the
rdma_ctrl_sync_fix
branch
from
a418a10 to
bb32ff8
Compare
|
Rebased on master |
rauteric
force-pushed
the
rdma_ctrl_sync_fix
branch
from
bb32ff8 to
5205e62
Compare
This lock will be used more generally. Signed-off-by: Eric Raut <eraut@amazon.com>
We hit a bug where the sender sends a long run of eager messages and ends up outpacing the receiver by more than the width of the message buffer, causing an error. In this patch, receiver will send a control message to sender at least every `msgbuff_size - max_requests` messages, and sender will pause if it hasn't received a control message within this duration. Signed-off-by: Eric Raut <eraut@amazon.com>
|
Addressed feedback from Nick |
rauteric
force-pushed
the
rdma_ctrl_sync_fix
branch
from
5205e62 to
8dc7adf
Compare
|
Rebased on master |
ghost
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit a bug where the sender sends a long run of eager messages and
ends up outpacing the receiver by more than the width of the message
buffer, causing an error.
In this patch, receiver will send a control message to sender at least
every
msgbuff_size - max_requestsmessages, and sender will pause ifit hasn't received a control message within this duration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.