Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate out 3rd-party headers #634

Merged
18 commits merged into from
Oct 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(freelist): add missing stdbool.h include
C99 does not define bool as a keyword (unlike C11 and beyond), which
means that files are free to use `bool` as something other than a type
name. When <stdbool.h> is not included through some other mechanism,
-Wc++-compat treats it as such and complains that it's a reserved
keyword in C++.

freelist.h uses bool, but does not bring in stdbool.h; add <stdbool.h>

Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Nicholas Sielicki committed Oct 8, 2024

Verified

This commit was signed with the committer’s verified signature.
commit f22945c5b902723a1c3dfc77acaa555ce4e7ca04
1 change: 1 addition & 0 deletions include/nccl_ofi_freelist.h
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@
extern "C" {
#endif

#include <stdbool.h>
#include <assert.h>
#include <stdlib.h>
#include <pthread.h>