fix(ci): prefer ecr to dockerhub #628
Merged
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
rauteric
approved these changes
Sep 27, 2024
AmedeoSapio
pushed a commit
to AmedeoSapio/aws-ofi-nccl
that referenced
this pull request
Oct 3, 2024
Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com> (cherry picked from commit 0ff714b)
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
AmedeoSapio
pushed a commit
that referenced
this pull request
Oct 4, 2024
Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com> (cherry picked from commit 0ff714b)
bwbarrett
pushed a commit
that referenced
this pull request
Oct 24, 2024
Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com> (cherry picked from commit 0ff714b)
a-szegel
pushed a commit
to a-szegel/aws-ofi-nccl
that referenced
this pull request
Nov 6, 2024
Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com> (cherry picked from commit 0ff714b)
a-szegel
pushed a commit
that referenced
this pull request
Nov 12, 2024
Pulls have been occasionally failing distcheck jobs since 83f563c moved these jobs from codebuild "self-hosted" runners to just run atop the gha standard runners with docker. Try using ECR instead in the hopes that we are not rate limited there. Signed-off-by: Nicholas Sielicki <nslick@amazon.com> (cherry picked from commit 0ff714b)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls have been occasionally failing distcheck jobs since 83f563c moved
these jobs from codebuild "self-hosted" runners to just run atop the gha
standard runners with docker. Try using ECR instead in the hopes that we
are not rate limited there.
Signed-off-by: Nicholas Sielicki nslick@amazon.com
Example failure: https://github.com/aws-nslick/nccl-net-ofi/actions/runs/11063619034/job/30740033833#step:2:26