fix(build): ensure -pthread is passed #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
previously requested changes
Sep 26, 2024
Linking against pthread and adding the compiler/linker/preprocessor option for pthread are different things. Without the compiler/preprocessor options, various builtin '#define's may not be set. Notably, this should change the behavior around errno in a multithreaded context within glibc; _REENTRANT will now be defined and errno is now thread-local. See 4e45dd8 for an example of a bug that this would have prevented. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
force-pushed
the
pthread-fixes
branch
from
bd61ce3 to
8158c7b
Compare
rauteric
approved these changes
Sep 26, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Linking against pthread and adding the compiler/linker/preprocessor option for pthread are different things. Without the compiler/preprocessor options, various builtin '#define's may not be set. Notably, this should change the behavior around errno in a multithreaded context within glibc; _REENTRANT will now be defined and errno is now thread-local. See 4e45dd8 for an example of a bug that this would have prevented. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
Background: https://developers.redhat.com/articles/2021/12/17/why-glibc-234-removed-libpthread
4e45dd8 for a bug that this would have caught.
Why in both CFLAGS and CPPFLAGS? https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-pthread
Why in LDFLAGS? https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html#index-pthread-1
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.