fix(build): add missing AC_PROG_RANLIB #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automake manual: > This is required if any libraries are built in the package. See > Particular Program Checks in The Autoconf Manual. add this for correctness. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
requested a review
from 
bwbarrett
approved these changes
Sep 26, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Automake manual: > This is required if any libraries are built in the package. See > Particular Program Checks in The Autoconf Manual. add this for correctness. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ranlib is already being used, but this just adds the automake hook to ensure
that it can be resolved..
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.