Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci/github): use docker instead of codebuild #608

Merged
2 commits merged into from
Sep 19, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2024

feat(ci/github): use docker instead of codebuild

codebuild runners seems to get stuck for us regularly for whatever
reason, just use docker and the al2023/al2 images that exist there.
Other fixes: use the amzn2023 cuda repo, bump cuda versions that these
builds operate against.

Signed-off-by: Nicholas Sielicki <nslick@amazon.com>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ghost ghost force-pushed the actions-fixups branch 5 times, most recently from 2e0e6a1 to fc024fd Compare September 17, 2024 23:29
@ghost ghost marked this pull request as ready for review September 17, 2024 23:31
@ghost ghost requested a review from rajachan as a code owner September 17, 2024 23:31
Nicholas Sielicki added 2 commits September 18, 2024 12:14
be a bit more frugal and don't require pr-ci to run when validating
changes to eg: jenkins ci.

Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
codebuild runners seems to get stuck for us regularly for whatever
reason, just use docker and the al2023/al2 images that exist there.
Other fixes: use the amzn2023 cuda repo, bump cuda versions that these
builds operate against.

Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
@ghost ghost force-pushed the actions-fixups branch from fc024fd to 005c2b9 Compare September 18, 2024 19:15
@ghost ghost merged commit 83f563c into aws:master Sep 19, 2024
31 checks passed
@ghost ghost deleted the actions-fixups branch September 19, 2024 13:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant