tuner: Enable tuner init msg on INFO logs #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
approved these changes
Aug 29, 2024
AmedeoSapio
approved these changes
Aug 29, 2024
|
bot:aws:retest |
2 similar comments
|
bot:aws:retest |
|
bot:aws:retest |
|
Can you please remove the merge commit? If you didn't intend for that to happen, consider adopting the following git settings: LGTM otherwise. |
bwbarrett
requested changes
Sep 3, 2024
Enable tuner initialization message to be displayed on all NCCL_DEBUG=INFO and display the logs as part of the default subsystem (INIT) Signed-off-by: Arun Karthik <akkart@amazon.com>
arunkarthik-akkart
force-pushed
the
tuner_init_msg
branch
from
8136aa9 to
52edb7e
Compare
Thanks for the feedback, I have rebased the PR after removing the merge commit. |
Thanks. I have rebased the PR after removing the merge commit. |
bwbarrett
approved these changes
Sep 3, 2024
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enable tuner initialization message to be displayed on all NCCL_DEBUG=INFO and display the logs as part of the default subsystem (INIT)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.