Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix efa installer caching #546

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2024

Description of changes:

Unfortunately, this couldn't be tested without introducing the action to the repo in the master branch so that the action appeared in the UI. It was implemented with a script issue. This fixes that script issue, and can be tested before merging now that the initial action was introduced to the repository.

https://github.com/aws/aws-ofi-nccl/actions/runs/10604329005

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ghost ghost requested a review from rajachan as a code owner August 28, 2024 21:01
Unfortunately, this couldn't be tested without introducing the action to the
repo so that the action appeared in the UI.  It was implemented with a script
issue. This fixes that script issue, and can be tested before merging now that
the initial action was introduced to the repository.
@ghost
Copy link
Author

ghost commented Aug 28, 2024

This must merge to master to unblock PRs relying on it, as caches are branch specific.

@ghost ghost force-pushed the cache-efa-installer-fix branch from 1a2300d to 4f39218 Compare August 28, 2024 22:28
@rajachan rajachan merged commit 49dacb8 into aws:master Aug 29, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant