Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormRenderer-Wizard): Fix an issue where validation can be skipped in certain scenarios. Close #991 #995

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jessieweiyi
Copy link
Contributor

Issue #, if available:

#991

Description of changes:

This PR is to fix an issue where validation can be skipped in certain scenarios, for instance, the scenarios specified in the issue #991 by using a maximum step index parameter. If the active step index is less than the maximum step index (For the scenario that the user has visited a page after the current page and navigated back), the validation will be triggered.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi changed the title fix(FormRenderer-Wizard): Fix an issue where validation can be skipped in certain scenarios fix(FormRenderer-Wizard): Fix an issue where validation can be skipped in certain scenarios. Close Oct 30, 2023
@jessieweiyi jessieweiyi changed the title fix(FormRenderer-Wizard): Fix an issue where validation can be skipped in certain scenarios. Close fix(FormRenderer-Wizard): Fix an issue where validation can be skipped in certain scenarios. Close #991 Oct 30, 2023
@jessieweiyi jessieweiyi merged commit c0b2f53 into main Oct 30, 2023
3 checks passed
@jessieweiyi jessieweiyi deleted the fix/wizard-validation branch October 30, 2023 22:43
@aws-prototyping-bot
Copy link
Collaborator

🎉 This PR is included in version @aws-northstar/ui-v1.1.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants