fix: BREAKING CHANGE - List @cloudscape-design/components as peer dependencies #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessieweiyi
changed the title
|
🎉 This PR is included in version @aws-northstar/ui-v1.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When @cloudscape-design/components is also listed as project dependencies, 2 different versions of @cloudscape-design/components may be installed. This may cause inconsistency in AppLayout rendering.
This PR is to move @cloudscape-design/components out from dependencies and list it as peer dependencies. Consumer projects has to install it explicitly. For most use cases, @cloudscape-design/components is listed as project dependencies already to support usage of native Cloudscape components so it should not impact majority of users.
This PR is also to list react-markdown as dependency and clean up peer dependencies (should not have direct user impacts)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.