Prometheus metric leak #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#925 #665
Description of changes:
NTH's prometheus metric, "actions_node", has a high cardinality due to its "node_name" and "node_event_id" labels. This causes each event to be tracked as its own time-series, which can cause a large amount of memory to be consumed over time.
A new metric, "actions", has been created without the "node_name" and "node_event_id" labels, greatly reducing the cardinality of the metric. The "actions_node" metric has been deprecated and the "actions" metric is recommended for use instead. The "actions_node" metric is planned for removal in later releases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.