ASG Launch Lifecycle Hook #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before ASG termination event
… not completed by NTH to allow for Capacity Rebalance
Add functionality for NTH to catch and complete ASG launch lifecycle hooks. Created acceptance test script to test ASG launch lifecycle hook completion
…tns in ASG launch lifecycle calls
…istinct handlers for different interruption event Kinds
…ASG launch lifecycle bash script Refactored interruption event handling into a seperate package with distinct handlers for different interruption event Kinds. Updated ASG launch lifecycle hook acceptance test and eks-cluster run-test
…aunch lifecycle event
…Updated test timeouts to match Assertionscript standards
GavinBurris42
force-pushed
the
ASG_Hook
branch
from
dc6be0f
to
a8197a4
Compare
cjerad
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#292
Description of changes:
In SQS mode, NTH now can catch ASG launch lifecycle events. NTH completes the launch lifecycle hook if the newly launched instance is found and ready as a node.
In order to allow for Capacity Rebalance's launch-before-termination, NTH no longer completes the ASG termination lifecycle hook.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.