Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to uncordon on startup in Queue Processor mode #743

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

johngmyers
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

The documentation states:

The Queue Processor Mode does not allow for fine-grained configuration of which events are handled through helm configuration keys.

The .Values.enableScheduledEventDraining helm configuration key does control one aspect of NTH in Queue Processor mode: whether upon startup it attempts to uncordon the node it is running on.

This appears to be a bug. There is no logical reason for NTH to uncordon the node it is running on when not in IMDS mode.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johngmyers johngmyers requested a review from a team as a code owner December 10, 2022 05:53
@johngmyers
Copy link
Contributor Author

@peteroruba you missed this one.

Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

This will also be important when we remove PodSecurityPolicy (#638), because we want Queue Processor mode to be able to run in a Baseline or Restricted namespace. One thing that would require NTH to run in a Privileged namespace is filesystem access, and this feature tries to read /proc/uptime. That will still be necessary for IMDS mode, but QP mode doesn't need it. Thanks for making that actually true. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants