Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Clarify distinctions between IMDS and QP modes #695

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

snay2
Copy link
Contributor

@snay2 snay2 commented Sep 28, 2022

Issue #, if available: N/A

Description of changes:

Make the difference between IMDS and Queue Processor modes easier to understand. Clarify the formatting, standardize the terminology, add links to AWS documentation, and simplify the table.

For a preview, see the rendered version on my branch: https://github.com/snay2/aws-node-termination-handler/blob/clarify-readme/README.md#major-features

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@snay2 snay2 requested a review from a team as a code owner September 28, 2022 19:52
Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants