helm: Apply extraEnv to daemonsets #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snay2
reviewed
Aug 18, 2022
There was a problem hiding this comment.
Yes, you are correct that this repo is the right place to make helm chart changes. After we release here, the changes will propagate to the eks-charts repo.
I agree that removing extraEnv from the daemonset templates (but leaving it in the deployment template) was an oversight during the refactor in #540. Thanks for fixing it!
snay2
approved these changes
Aug 18, 2022
|
This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was (accidentally I presume) removed in #540
I think helm changes are made here and not on the eks-charts repo?
If that's not correct I'm happy to open this there instead!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.