-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dev guide and resources #660
Conversation
* Shorten EventBridge rule name suffixes
* Display help message * Run test suite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this resolves the issues I had.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved the issues that I had earlier, as discussed offline, creating bin directory should be included in makefile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm 👍
LGTM 👍 Thanks, Jerad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks Jerad 👍
Issue #, if available:
Description of changes:
make apply
now uses the value ofCLUSTER_NAMESPACE
rather than a hardcoded namespaceko
is now installed from a pre-built binary rather than usinggo install
to workaround a build issue in the ko projectmake help
andmake test
Terminator
objects will now appear in the "all" category (e.g.kubectl get all -n <namespace>
)CLUSTER_NAMESPACE
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.