Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AssumeAsgTagPropagation #632

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Remove AssumeAsgTagPropagation #632

merged 5 commits into from
Apr 25, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: #616

Description of changes:

  • Removes AssumeAsgTagPropagation flag, config, logic, and tests because instances should ways be tagged
  • Leverage ASG APIs iff checkASGTagBeforeDraining: true (default)

Context:

  • The original PR introducing AssumeAsgTagPropagation also mentions this is probably not needed:

I left in the code which, in cases where an instance does not have an aws:autoscaling:groupName tag, assumes that the instance might nonetheless belong to an ASG and calls the autoscaling API to make sure. I'm not sure these code paths need to exist. Is that aws:autoscaling:groupName tag a Sufficiently Official AWS Feature that we can get rid of that logic and just assume the tag will always be there?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from a team as a code owner April 22, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants