-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EOL kubernetes version #617
Conversation
Merge from upstream
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ngoyal16, thanks for staying on top of these version updates!
Historically, we've kept the 6 most recent k8s versions in the testing matrix. I'm fine with removing 1.17
now, but can you also add 1.23
into the matrix as well?
(Looks like 1.24 should be released next week and EKS should be dropping 1.18 support soon, so we can come back and update this matrix again in a few weeks.)
@snay2 Kubernetes v1.18 support is already droped by EKS on 31st march, 2022. also could you provide the docker kind image url for the v1.23 for testing |
Good point, we can remove 1.18 as soon as 1.24 is released this month. The latest minor version of 1.23 available, per https://hub.docker.com/r/kindest/node/tags, is 1.23.5. Here's the image identifier:
(I got that with this command, if you want to verify:)
|
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@snay2 1.23 support is added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Issue #, if available:
Description of changes:
EOL kubernetes version support compatiblity test removed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.