Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knative webhook #596

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Knative webhook #596

merged 6 commits into from
Mar 3, 2022

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Feb 25, 2022

Issue #, if available:

#556 Initial NTH v2 design proposal

Description of changes:

  1. Move controller to cmd/controller sub-directory
  2. Migrate controller to knative
  3. Add webhook using knative to cmd/webhook
  4. Update helm chart

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad requested a review from a team as a code owner February 25, 2022 15:58
bwagner5
bwagner5 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cjerad cjerad merged commit 26fd00d into aws:v2 Mar 3, 2022
@cjerad cjerad deleted the knative-webhook branch March 3, 2022 16:53
@ec2-bot ec2-bot mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

Assignees

@bwagner5 bwagner5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjerad @bwagner5