-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace kustomize with helm #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I just had one comment on moving the tool installs to a hack/toolchain.sh
script. I don't want the Makefile to get out of control. It should be really simple stuff in it. Feel free to merge this and do in a follow-up PR though.
src/Makefile
Outdated
KO = $(shell pwd)/bin/ko | ||
.PHONY: ko | ||
ko: ## Download ko locally if necessary. | ||
$(call go-get-tool,$(KO),github.com/google/ko@v0.9.3) | ||
|
||
ENVTEST = $(shell pwd)/bin/setup-envtest | ||
.PHONY: envtest | ||
envtest: ## Download envtest-setup locally if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move these tool installs to hack/toolchain.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue #, if available:
#556 Initial NTH v2 design proposal
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.