-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Add servicemonitor #517
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
/assign @bwagner5 |
@bwagner5 I've spotted a number of issues with the Helm chart that should probably be tidied up, would you be interested in a PR for that after this has been merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good
/approve
@@ -100,6 +95,11 @@ Parameter | Description | Default | |||
`workers` | The maximum amount of parallel event processors | `10` | |||
`replicas` | The number of replicas in the NTH deployment when using queue-processor mode (NOTE: increasing replicas may cause duplicate webhooks since NTH pods are stateless) | `1` | |||
`podDisruptionBudget` | Limit the disruption for controller pods, requires at least 2 controller replicas | `{}` | |||
`serviceMonitor.create` | If `true`, create a ServiceMonitor (this requires enableSqsTerminationDraining and enablePrometheusServer to be set) | `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you don't need to include the bit about enableSqsTerminationDraining
because these configs are in their respective sections already(QP vs IMDS)
Yes, absolutely! :) thanks |
@bwagner5 I'll wait for this to be merged and then open a new PR based on the updated main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! lgtm
Fixes #516.
Description of changes:
Service
resource ifenableSqsTerminationDraining=true
andenablePrometheusServer=true
serviceMonitor
config to allow the creation of aServiceMonitor
resource viaserviceMonitor.enabled=true
ifenableSqsTerminationDraining=true
andenablePrometheusServer=true
PodMonitor
resource viapodMonitor.enabled=true
ifenableSqsTerminationDraining=false
andenablePrometheusServer=true
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.