feat(chart): Stop using hostPort on deployment #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
|
/assign @bwagner5 |
|
@bwagner5 I thought that chart changes here were automatically PRed into aws/eks-charts? I can't see a PR for these changes that have been released in v1.34.4. |
|
@stevehipwell You are correct. The PR is supposed to be created automatically, but that step of the build failed on Friday. Re-running now and will debug if it fails again. |
|
Released! Apologies for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500.
Description of changes:
hostPortin DeploymenthostPortsif neededenableProbesServer: trueBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.