Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-node-termination-handler chart: use .Values.webhookTemplateConfig* parameters #488

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

stanvit
Copy link
Contributor

@stanvit stanvit commented Aug 27, 2021

Using .Values. webhookTemplateConfigMapName and .Values. webhookTemplateConfigMapName in the Queue Processor mode Deployment, the same way it's done in the Daemonsets.

Resolves #487

@bwagner5 bwagner5 self-requested a review August 27, 2021 15:00
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for bringing these to parity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webhookTemplateConfigMap* parameters are not respected in helm chart
2 participants