fix(chart): added missing livenessProbe #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can you remove the chart version increment? Our automated syncing process will take care of incrementing the version so that it can batch chart changes to a single version change. |
bwagner5
requested changes
Jul 20, 2021
|
@bwagner5 Done :) |
|
@bwagner5 Would it be possible to get a release published with this fix? It's currently one of the only 3rd party apps in our cluster missing probes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The chart was missing the actual livenessProbe, even though it was defined in the values.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.